fix: use await asyncio.sleep instead of blocking time.sleep in async voter retry#6243
Open
kratos0718 wants to merge 1 commit into
Open
fix: use await asyncio.sleep instead of blocking time.sleep in async voter retry#6243kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
…voter retry The retry loop in _async_call_add_voters awaits async_call_add_voter but backs off with a blocking time.sleep(2.0), freezing the event loop for 2s per retry (up to ~10s across 5 attempts). Use await asyncio.sleep so the loop stays free. The sync sibling _call_add_voters is left unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
jina/orchestrate/deployments/__init__.py, the voter-add retry loop runs inside an async function (itawaitsasync_call_add_voter), but its back-off uses a blockingtime.sleep(2.0):time.sleepblocks the entire event loop for its duration — 2s per retry, up to ~10s across the 5 attempts. While it sleeps, every other coroutine on the loop is frozen.Fix
Use
await asyncio.sleep(2.0), which backs off without blocking the loop.asynciois already imported; behavior is otherwise identical.python -m py_compile).