feat(external-api): send full user context#17147
Merged
mihhu merged 1 commit intojitsi:masterfrom Mar 24, 2026
Merged
Conversation
saghul
reviewed
Mar 19, 2026
| id: userIdentity.id, | ||
| name: userIdentity.name | ||
| } : undefined; | ||
| const userContext = userIdentity ? { ...userIdentity } : undefined; |
Member
There was a problem hiding this comment.
Why create the copy? Feels like we should do userContext: userIdentity below?
saghul
reviewed
Mar 19, 2026
| id: jwtUser.id, | ||
| name: jwtUser.name | ||
| } : undefined; | ||
| const userContext = jwtUser ? { ...jwtUser } : undefined; |
14eadf1 to
c205130
Compare
saghul
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs this built & updated first: jitsi/lib-jitsi-meet#2992