Refactor statsEmitter to normalize stats without mutation.#17166
Open
Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Open
Refactor statsEmitter to normalize stats without mutation.#17166Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the handling of connection stats in
statsEmitter.tsto improve type safety and reduce technical debt, successfully resolving a longstanding FIXME.Currently, stats received from
lib-jitsi-meet(such as framerate, resolution, and codec) are provided as maps keyed by user IDs. However, frontend consumers expect these values as primitives for individual users. The existing implementation handled this mismatch by overriding the stats object inline alongside aFIXMEnote, while maintaining a generic and inaccurateIStatsTypeScript interface.Changes made
IRawStatsandIFormattedStatsTypeScript interfaces to accurately reflect the incoming library data vs. the outgoing frontend data._onStatsUpdatedto explicitly normalize stats into per-user formatted objects using an Adapter Pattern.Why this change
Impact
Related Issue
Fixes #17165