Refactor: Extract track streaming status to custom hook#17171
Open
Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Open
Refactor: Extract track streaming status to custom hook#17171Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Aashuti-Tech-Trek wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two
TODOcomments inreact/features/connection-indicator/components/web/ConnectionIndicatorIcon.tsxby extracting the track streaming status listeners into a clean, reusable React custom hook. Currently, theConnectionIndicatorIconcomponent manually listens toJitsiTrackEvents.TRACK_STREAMING_STATUS_CHANGEDand dispatches to the Redux store via an inline useEffect. The original authors explicitly noted this should be rewritten into a standalone hook that maintains a local status reference.Changes made
useTrackStreamingStatus(track)custom hook insidereact/features/connection-indicator/hooks.ts.ConnectionIndicatorIcon.tsxto utilize the new hook, drastically simplifying the component's internal logic and reducing its dependency on manual event listener teardowns.Why this change
(TODO).Related Issue Fixes #17170