feat(keyboard-shortcuts): add alternativeShortcutKeys config for layout-independent shortcuts#17176
Open
iospro wants to merge 1 commit intojitsi:masterfrom
Open
feat(keyboard-shortcuts): add alternativeShortcutKeys config for layout-independent shortcuts#17176iospro wants to merge 1 commit intojitsi:masterfrom
iospro wants to merge 1 commit intojitsi:masterfrom
Conversation
…ame behaviour for any keyboard layout)
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On non-QWERTY keyboard layouts (e.g. AZERTY, QWERTZ, Cyrillic) the physical keys produce different characters, so existing single-key shortcuts (like
A,V,C) stop working correctly — the keypress event delivers the layout-specific character rather than the intended one.Solution
Add an
alternativeShortcutKeysconfig option that maps alternative key codes to their primary shortcut equivalents. When a keydown event doesn't match any registered shortcut directly, the handler looks up whether the pressed key has a primary mapping and dispatches that shortcut instead.Changes
config.js— documents newalternativeShortcutKeysoption:Array<{ key: string; alt: string }>configType.ts— adds TypeScript type foralternativeShortcutKeysconfigWhitelist.ts— allowsalternativeShortcutKeysto be overridden viaconfigOverwritekeyboard-shortcuts/functions.ts— addsgetPrimaryShortcutKey(state, altKey)selectorkeyboard-shortcuts/actions.ts— extendskeyDownHandlerto resolve alternative keys before shortcut lookupUsage