fix(conference): suppress redundant reason dialog on host-terminated session#17177
Open
iospro wants to merge 1 commit intojitsi:masterfrom
Open
fix(conference): suppress redundant reason dialog on host-terminated session#17177iospro wants to merge 1 commit intojitsi:masterfrom
iospro wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a moderator ends the conference for all participants via "End meeting for all",
the server sends
CONFERENCE_DESTROYEDwith reason"The meeting has been terminated".This reason string gets passed to
hangup()/notifyConferenceFailed()and shows upas an error dialog to participants — even though it is not an error, but a normal
intentional termination by the host.
Solution
Check the destroy reason against
TRIGGER_READY_TO_CLOSE_REASONS['dialog.sessTerminatedReason'](the single source of truth already defined in
constants.ts) and pass an emptylocalizedReasonin that case, suppressing the redundant error notification.Changes
middleware.web.ts— extractlocalizedReason, clear it forsessTerminatedReasonmiddleware.native.ts— same fix for React Native pathBehaviour