fix(mobile/navigation): fix conference join hang when SDK launched in background#17180
Open
iospro wants to merge 1 commit intojitsi:masterfrom
Open
fix(mobile/navigation): fix conference join hang when SDK launched in background#17180iospro wants to merge 1 commit intojitsi:masterfrom
iospro wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the Jitsi Meet SDK is embedded in a host app and the host app launches the SDK
programmatically in response to an incoming call notification — while the device is
locked and the screen is off — joining the conference room hangs indefinitely.
Root cause:
App.native._extraInit()awaits arootNavigationReadypromise thatresolves only when
NavigationContainerfires itsonReadycallback. When the appruns in the background (device locked, no UI on screen), React Navigation never renders
or fires
onReady, so the polling loop spins forever and the conference join neverproceeds.
A secondary issue: without Welcome Page (embedded SDK mode),
initialRouteNamewasscreen.connecting, but when a room URL is already known at launch the navigatorshould start at
screen.conference.rootto avoid an unnecessary intermediate screen.Solution
App.native.tsx— detect background SDK launch usingAppState.currentState !== 'active'combined with the presence of a
urlprop. Skipawait rootNavigationReadyin this caseso the join flow proceeds immediately without waiting for UI to become visible.
RootNavigationContainer.tsx— deriveinitialRouteNamefrom Redux state:if a
roomis already set at mount time (meaning the SDK was started with a conferenceURL), navigate directly to
screen.conference.root; otherwise usescreen.connectingas before.
Behaviour
AppStateurlpropawaitskippedinitialRouteactiveconnectingactiveconnecting→ navigatebackgroundconference.root