feat(toolbox/native): add platform-specific toolbar thresholds for iOS and Android#17187
Open
iospro wants to merge 1 commit intojitsi:masterfrom
Open
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IOS_THRESHOLDS) and Android (ANDROID_THRESHOLDS) based on real device screen widthsPlatform.OSNATIVE_THRESHOLDSkept as an alias toIOS_THRESHOLDSfor Redux initial state compatibilityChanges
toolbox/constants.tsIOS_THRESHOLDS(428, 375) andANDROID_THRESHOLDS(412, 360);NATIVE_THRESHOLDSaliased toIOS_THRESHOLDStoolbox/middleware.native.tsPlatform.OScheck to dispatch platform-specific thresholds on config loadtoolbox/functions.native.tsiOS breakpoints (points)
Android breakpoints (dp)
Why disable single-button overflow promotion
The original logic automatically moved a button from the overflow menu into the main toolbar when only one button remained in overflow. This caused unpredictable toolbar layout: the "More" button would disappear and a random button would appear in its place depending on which features were enabled. With explicit per-platform thresholds the button sets are already carefully defined — auto-promotion contradicts that intention and produces inconsistent UX across devices and configurations.