feat(toolbox): add DESTRUCTIVE button type for hangup button on native#17188
Open
iospro wants to merge 1 commit intojitsi:masterfrom
Open
feat(toolbox): add DESTRUCTIVE button type for hangup button on native#17188iospro wants to merge 1 commit intojitsi:masterfrom
iospro wants to merge 1 commit intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DESTRUCTIVEbutton type toIconButtonfor native, styled with design system danger tokensDESTRUCTIVEtype to the hangup button, replacing custom color scheme with semantic stylingrgb(227,79,86)withColorPalette.redandBaseTheme.palette.actionDangerChanges
base/ui/components/native/IconButton.tsxDESTRUCTIVEbranch: white icon,actionDangerbackground,darkGreyunderlaybase/react/components/native/styles.tsiconButtonContainerDestructivestyle withactionDangerbackgroundtoolbox/components/native/HangupMenuButton.tsxPRIMARYtoDESTRUCTIVEtoolbox/components/native/styles.tsBaseTheme.palette.actionDangerbase/color-scheme/defaultScheme.tsrgb(227,79,86)withColorPalette.redMotivation
The hangup button is a destructive action — ending a call. Using a generic
PRIMARYtype with a custom color bypassed the design system. The newDESTRUCTIVEtype uses semantic tokens (actionDanger) making the color consistent with other danger actions across the app and easy to theme.