fix(invite): preserve %20 in dial-in room query param#17195
fix(invite): preserve %20 in dial-in room query param#17195damencho merged 2 commits intojitsi:masterfrom
Conversation
|
Hi, thanks for your contribution! |
|
I’ve signed the Individual CLA. Please let me know if anything else is needed from my side. |
|
Fixes #16958 |
|
Have you checked all places where this is used and tested that this is not breaking anything? I don't think this is correct. |
|
Hi @damencho, I double-check the approach.
My initial fix was to preserve Before proceeding further, I wanted to confirm the preferred approach: Should we : Normalize the room value at the UI level (e.g. replace |
As it is known that the room name came from a url parameter then it just needs to be url decoded(decodeURIComponent). |
|
I tried using only decodeURIComponent("test+room") // "test+room"In our case, spaces are encoded as Would it make sense to normalize |
|
You can use URLSearchParams to catch all cases for decoding. |
|
I've updated the implementation to use URLSearchParams for retrieving the room value instead of manual decoding. This correctly handles both Also removed the previous change in Please let me know if this looks good! |
|
jenkins test this please |
|
Hi @damencho, Thanks again for the review and merge! I’m planning to apply for GSoC with Jitsi this year and wanted to get your guidance. I’ve been contributing recently (3 PRs merged so far) I wanted to ask:
Thanks again! |
Summary
Fixes the alpha dial-in flow where rooms with spaces are rendered as
test+roominstatic/dialInInfo.html.Root cause
The dial-in URL is built with
URLSearchParams, which encodes spaces in query params as+. The dial-in page later decodes the param for display, butdecodeURIComponentdoes not convert+to spaces, so the UI renderstest+room.Fix
Preserve spaces as
%20inappendURLParam()by replacing+with%20in the final URL string.Repro
https://alpha.jitsi.net/test roomtest+roomtest%20room