Provide partial WebAssembly support#55
Merged
jjjkkkjjj merged 36 commits intojjjkkkjjj:masterfrom Jan 21, 2026
Merged
Conversation
… should fail because the code is still not modified
Add CI support for Web Assembly
… some documentation + scripts
Fix iOS CI, update WASM CI for testing and add some utility scripts
…mplement this part
Project WASM compatibility first step
jjjkkkjjj
approved these changes
Jan 21, 2026
Owner
jjjkkkjjj
left a comment
jjjkkkjjj
left a comment
There was a problem hiding this comment.
Thank you so much for your hard work!!
I'm not very familiar with WASM yet, but I really appreciate this contribution — it will definitely help extend Matft’s use cases in the future.
| // dynamic allocation | ||
| self.data_real = allocate_doubledata_from_flattenArray(&flatten_realArray, toBool: mftype == .Bool) | ||
| self.data_imag = allocate_floatdata_from_flattenArray(&flatten_imagArray, toBool: mftype == .Bool) | ||
| self.data_imag = allocate_doubledata_from_flattenArray(&flatten_imagArray, toBool: mftype == .Bool) |
Owner
There was a problem hiding this comment.
Good catch!
This was fatal bug...
|
|
||
| /// Tests for WASI fallback implementations | ||
| /// These tests validate the pure Swift implementations that are used when Accelerate is not available (e.g., on WASI) | ||
| /// The tests run on macOS to ensure the fallback logic is correct before deploying to WASI |
Owner
There was a problem hiding this comment.
For the future, it would be nice if we could reuse the existing test suite and run the same tests against both Accelerate and WASI backends, but this is totally fine as a starting point.
Contributor
Author
There was a problem hiding this comment.
I actually configured the CI to execute the tests with the wasm toolchain as well, so these tests are executed with both toolchains. The comment is not correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to be an initial entry point for WebAssembly support. We've basically followed these steps to build a first PR we can later iterate on and improve depending on our future needs.
In the future we will continue contributing to this repository if you don't mind 😃 Thanks for all the hard work and the awesome library!