Support scanning of buildScripts / used gradle plugins #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balrok
force-pushed
the
feature/buildscript-scan
branch
from
3c92e44 to
5cd8860
Compare
Contributor
Author
|
@chadlwilson / @bdellegrazie / @jk1 what do you think about the PR? If there is interest, I can rebase it. |
Owner
|
Hi @balrok! This is rather unusual to track build script dependencies since they are not shipped or otherwise used in production. |
For this, the buildScriptProjects configuration option was introduced. It respects all other configuration like 'configurations'. The implementation is utilizing the existing ProjectReader for this because the required fields (`configurations` and `dependencies`) can also be found in ScriptHandler. There is only a change required: to use a general data structure for accessing these fields.
Also I don't understand why it is called in the first place: https://docs.gradle.org/current/kotlin-dsl/gradle/org.gradle.api.artifacts/-configuration-container/detached-configuration.html According to the docs `Creates a configuration, but does not add it to this container.` it should be fine
balrok
force-pushed
the
feature/buildscript-scan
branch
from
5cd8860 to
0532295
Compare
Contributor
Author
|
Rebased and also added a commit: balrok@0532295 Reason it is needed: we have several plugins creating code for us. Also we want to better be safe than sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, we need to scan also the build-time dependencies for licenses. In gradle they can be access via
project.buildScript.For this, the buildScriptProjects configuration option was introduced. It respects all other configuration like 'configurations'.
The implementation is utilizing the existing ProjectReader for this because the required fields (
configurationsanddependencies) can also be found in ScriptHandler. There is only a change required: to use a general data structure for accessing these fields.