fix: align normalizer rules between SPDX+default; fixing minor attribution issues #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules have diverged somewhat. Synchronising them improves consistency between usages.
…sed on content There are various creative commons licenses, and it does not seem correct to normalise them to the somewhat dubious "PUBLIC DOMAIN" overall license. There are also a number of different public domain licenses recognised within SPDX including the CC ones (https://spdx.org/licenses), so this does not seem appropriate. We should remove these and add appropriate rules on license content as licenses are re-analyzed and matched to CC PD variants.
…tifiers These identifiers have been deprecated for some time now, as they are ambiguous. Although in practice the Java/Sun/Oracle projects using this license are technically "GPL-2.0-or-later" when you read the license text, it is impossible to know that from the license name, so better to just assume GPL-2.0-only (allowing `-or-later` licenses is more liberal/flexible)
Owner
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few clean-ups for correctness to the normalizer rules
(x|a)groups and do it consistently.Public-Domainfrom SPDX normalizer. This is not an SPDX ID, so this is wrong/misleading. We need proper rules for various "public domain" variants IMHO as you will see there are lots of public domain variants. independent of the true "public domain" meaning.Creative Commonsfrom matchingPublic Domainin thedefaultruleset. I cant find why this was added, but this is really not correct. There are multiple Public Domain CC (and non-CC) licenses, and many other licenses with and without attribution within CC but this regex is extremely broad. Arguably the other rules should be removed too since they are overly broad on content, but have left here for now.GPL-2.0-only WITH Classpath-Exception-2.0.GPL-2.0and such are deprecated. Matching rules are unchanged