fix: allow native TextResource types for allowedLicensesFile; correcting 3.0 documentation
#361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL objects are no longer accepted due to use of @input File which only allows - A String or CharSequence path, for example 'src/main/java' or '/usr/include'. - A String or CharSequence URI, for example 'file:/usr/include'. - A File instance. - A Path instance. - A Directory instance. - A RegularFile instance. - A URI or URL instance of file. - A TextResource instance.
…le API Also allows other canonical types such as URI, Path & Gradle RegularFile as documented by the error users will get if supplier the wrong type.
chadlwilson
force-pushed
the
tidy-up-allowed-licenses
branch
from
2c10882 to
f17a782
Compare
Collaborator
|
@chadlwilson I prefer this solution, then we can release and all will be well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed (completely off topic) in #337 (comment) the change in #341 changed the API signature here for 3.0 by requiring an
@InputFile.@bdellegrazie Given the breaking version number in
3.0and the relatively trivial workaround[1], I don't really think that is a problem if we document it properly. Could add a comment to the GitHub release to be specific if we want.There are Gradle-native ways to supply URL resources to inputs via the
TextResourcetypes.[1] for 3.0 or later
after this PR (delays retrieval until task needs to be configured)