Skip to content

Bugfix - Apply dtstart option when forceset: true#431

Open
jutaz wants to merge 1 commit intojkbrzt:masterfrom
jutaz:bugfix/apply-dtstart-forceset
Open

Bugfix - Apply dtstart option when forceset: true#431
jutaz wants to merge 1 commit intojkbrzt:masterfrom
jutaz:bugfix/apply-dtstart-forceset

Conversation

@jutaz
Copy link
Copy Markdown

@jutaz jutaz commented Oct 23, 2020

This PR fixes a bug which happens when using rrulestr in a similar way to this:

rrulestr('RRULE:FREQ=WEEKLY', {
  forceset: true,
  dtstart: new Date()
});

In the past (talking ~2.2.0 ish) this would apply dtstart and the created rules would have the dtstart. That's no longer the behavior. Having an explicit dtstart which could even override the DTSTART: specified in the rule was quite convenient, and this PR brings it back.

What's interesting is that this is already the behavior when one doesn't specify forceset: true.


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

@jbuck94
Copy link
Copy Markdown

jbuck94 commented Mar 17, 2023

@jakubroztocil please merge this PR. This bug is blocking my ability to use the library

@jutaz
Copy link
Copy Markdown
Author

jutaz commented Mar 29, 2025

@jakubroztocil is there a chance this PR would get merged? If so I'll address the code conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants