Fixed failed to parse sourcemaps error#593
Closed
Taskle wants to merge 1 commit intojkbrzt:masterfrom
Closed
Conversation
Collaborator
|
Thanks, for the contribution! The problem with this approach is it points to the What I propose we do instead is not minify the published output, then you won't even need sourcemaps. Most end-stage build tools minify the whole bundle including |
This was referenced Sep 4, 2024
|
I've create two PRs which fix the situation for now: @davidgoli I'd invite you to pick the one that makes more sense. Just having sourcemaps which point to non-existing source files makes not much, I'd say 🤙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue surfaced in #522 that generates console warnings for anyone who imports rrule into their project.
I've tested it locally in my forked version and it appears to remove the errors.