jaegermcp: restrict CORS to explicitly allowed origins#5
Closed
jaegermcp: restrict CORS to explicitly allowed origins#5
Conversation
|
Hi @jkowall, thanks for your contribution! To ensure quality reviews, we limit how many concurrent PRs new contributors can open:
This PR is currently on hold. We will automatically move this into the review queue once your existing PRs are merged or closed. Please see our Contributing Guidelines for details on our tiered quota policy. |
yurishkuro
reviewed
Mar 13, 2026
|
|
||
| // CORSAllowedOrigins controls which browser origins are allowed to call MCP endpoints. | ||
| // Empty means CORS is disabled. | ||
| CORSAllowedOrigins []string `mapstructure:"cors_allowed_origins"` |
There was a problem hiding this comment.
confighttp should already have cors options. Also, we have a similar pr opened elsewhere.
Owner
Author
|
Closing this in favor of the upstream Jaeger PR: jaegertracing#8128 jaegertracing#8128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CORSAllowedOrigins []string(config keycors_allowed_origins) to the Jaeger MCP extension config and keep it nil by default to disable CORS.Access-Control-Allow-Origin: *behavior with an allowlist-based middleware that setsVary: Originand returnsAccess-Control-Allow-Origin/preflight responses only for configured origins.Testing
make fmtcompleted successfully.make lintwas started and progressed through the lint pipeline but did not fully complete within this session.make testwas started but did not fully complete within this session due to environment time limits.go test ./cmd/jaeger/internal/extension/jaegermcp -run 'TestCORSPreflight|TestCORSPreflightDisallowedOrigin'were executed but timed out in this environment before finishing.Codex Task