customizable order for rotations & transformations#93
Open
mlarcher wants to merge 1 commit intojmpressjs:masterfrom
Open
customizable order for rotations & transformations#93mlarcher wants to merge 1 commit intojmpressjs:masterfrom
mlarcher wants to merge 1 commit intojmpressjs:masterfrom
Conversation
…teY before rotateX, or apply rotations before applying translations)
Member
|
I like the idea to make it more flexible.
Using different orders in steps may cause weird translations between them... |
Author
|
I'm sure there could be some optimizations :) |
|
+1 IS this going to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can come in handy to be able to force the rotation on the Y axis to occur before the one on the X axis, or to apply rotations before applying translations.
This pull request handles those cases, and won't interfere with the default behaviour.
It adds the following options :
rotateOrder: 'xyz'
Its value is a string that can be any combination of x,y and z.
Translations will be applied in that order.
transformOrder: 'trs'
Its value is a string that can be any combination of t, r and s.
t stands for translate, r for rotate and s for scale.
Transformations will be applied in that order.