Added timeout property to "connecting" event#86
Open
JonMcPherson wants to merge 1 commit intojoewalnes:masterfrom
Open
Added timeout property to "connecting" event#86JonMcPherson wants to merge 1 commit intojoewalnes:masterfrom
JonMcPherson wants to merge 1 commit intojoewalnes:masterfrom
Conversation
Knowing when the next reconnect attempt will be made is useful in some situations and simply for logging purposes. So why not include the timeout property in the "connecting" event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowing when the next reconnect attempt will be made is useful in some situations and simply for logging purposes.
So why not include the timeout property in the "connecting" event.