Skip to content

Restore legiond compatibility with kernel 6.14.6#319

Merged
st0nie merged 1 commit intojohnfanv2:mainfrom
LRitzdorf:fix-sigev-handler
May 21, 2025
Merged

Restore legiond compatibility with kernel 6.14.6#319
st0nie merged 1 commit intojohnfanv2:mainfrom
LRitzdorf:fix-sigev-handler

Conversation

@LRitzdorf
Copy link
Copy Markdown
Contributor

Linux kernel v6.14.6 (at least; possibly earlier) requires that sigevent.sigev_notify_function handlers accept a union sigval argument. This PR adds such an argument, although it is currently unused.

Maintainer feedback needed: Is that appropriate, or do we want to actually use sigev_value somewhere?

Fixes #318

This restores compatibility with (at least) Linux kernel 6.14.6.
@pgralv
Copy link
Copy Markdown

pgralv commented May 19, 2025

This patch is required to successfully build LenovoLegionLinux on Arch Linux.

Copy link
Copy Markdown
Collaborator

@st0nie st0nie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are correct, my previous parameters were irregular, and perhaps an update to the compiler or kernel headers made this code uncompilable.

@st0nie st0nie merged commit e4a0add into johnfanv2:main May 21, 2025
6 of 7 checks passed
@LRitzdorf LRitzdorf deleted the fix-sigev-handler branch May 21, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] legiond compilation fails under kernel 6.14.6: type mismatch involving struct sigev

3 participants