Skip to content

Add support for Legion Pro 7 16IAX10H (Q7CN, EC 0x5508)#396

Closed
ChaoticSi1ence wants to merge 2 commits intojohnfanv2:mainfrom
ChaoticSi1ence:main
Closed

Add support for Legion Pro 7 16IAX10H (Q7CN, EC 0x5508)#396
ChaoticSi1ence wants to merge 2 commits intojohnfanv2:mainfrom
ChaoticSi1ence:main

Conversation

@ChaoticSi1ence
Copy link
Copy Markdown

Add model_q7cn config for the 2025 Legion Pro 7 16IAX10H (83F5):

  • EC chip: ITE IT5508 (0x5508), verified on hardware
  • BIOS code: Q7CN
  • Fan curve/speed/temperature via WMI3
  • Power mode and fan full speed via WMI
  • RGB keyboard is USB-controlled (ACCESS_METHOD_NO_ACCESS)
  • Based on model_nscn (Legion 7 16IAX9) as closest match

Also fix minor line-length formatting in platform_profile_probe and platform_profile_init to comply with 80-column kernel style.

Add model_q7cn config for the 2025 Legion Pro 7 16IAX10H (83F5):
- EC chip: ITE IT5508 (0x5508), verified on hardware
- BIOS code: Q7CN
- Fan curve/speed/temperature via WMI3
- Power mode and fan full speed via WMI
- RGB keyboard is USB-controlled (ACCESS_METHOD_NO_ACCESS)
- Based on model_nscn (Legion 7 16IAX9) as closest match

Also fix minor line-length formatting in platform_profile_probe and
platform_profile_init to comply with 80-column kernel style.
@ChaoticSi1ence
Copy link
Copy Markdown
Author

CI Failure Analysis

Pushed commit 13dc531 to fix checkpatch //-style comment warnings in my Q7CN model code (now uses /* */ block comments).

Remaining CI failures are pre-existing on main

My PR only modifies kernel_module/legion-laptop.c (+36 lines). The Run Tests job failures are all in upstream code untouched by this PR:

Failure Root Cause
checkpatch.pl (step 4) Runs against the entire 6500-line file. The ~60 //-spacing warnings, spelling typos (temmperature, hysteris, etc.), and remaining long lines all pre-date this PR.
pylint (step 5) Warnings in legion_gui.py (unused vars w/h, broad-except) and legion_cli.py (unnecessary lambdas, unused **kwargs, broad-except) — all in boot logo code not touched by this PR.
test_python_cli.sh (step 6) ModuleNotFoundError: No module named 'PIL'legion.py imports from PIL import Image but Pillow is not listed in setup.cfg install_requires nor installed by any CI dependency script.
python_install_pip_pkg.sh git describe --tags fails in CI's shallow checkout (no tags fetched).

These would need a separate upstream fix. Happy to open an issue or a follow-up PR for them if that would help.

@gluceri
Copy link
Copy Markdown

gluceri commented Feb 21, 2026

@ChaoticSi1ence may I ask you why did you close this PR without merging?

@ChaoticSi1ence
Copy link
Copy Markdown
Author

@ChaoticSi1ence may I ask you why did you close this PR without merging?

I wanted to take it further and been messing with the whole project on my fork. I have it working 90% on my machine but I don't want to PR AI work over human code.

@gluceri
Copy link
Copy Markdown

gluceri commented Feb 21, 2026

I own a Legion Pro 7 16AFR10H having the same EC 0x5508 controller and done some tests.
You can find what I have found at #385 (comment)

Maybe it can help in your review.

Ping me if you need infos or tests

Regards

@ChaoticSi1ence
Copy link
Copy Markdown
Author

I own a Legion Pro 7 16AFR10H having the same EC 0x5508 controller and done some tests. You can find what I have found at #385 (comment)

Maybe it can help in your review.

Ping me if you need infos or tests

Regards

I'm not sure how to implement your device into my work, I had completely pulled acpi and wmi info from windows to get it set up. This is no longer a project that is expandable for me as the code for LLL is very broken. You can try my fork and add your model to the kernel.c and copy my profile. I was tired of waiting for this project to do anything significant so I just slammed it with Claude Opus 4.6 and it almost fully works on my laptop. So I closed my pull request sadly. I'm not a dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants