Skip to content

fix: Y-Logo LED GET/SET byte mismatch and IO-Port init on Gen 10 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alstergee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Y-Logo LED GET/SET byte mismatch and IO-Port init on Gen 10 #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions kernel_module/legion-laptop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3788,6 +3788,14 @@ static int legion_wmi_light_get(struct legion_private *priv, u8 light_id,
return -EIO;
}

if (light_id == LIGHT_ID_YLOGO) {
/* Y-Logo: DSDT returns on/off state in byte 0 (LCST).
* EC convention: 1 = ON, 2 = OFF.
* Map to sysfs brightness: 1 or 0.
*/
return (result[0] == 1) ? 1 : 0;
}

value = result[1];
if (!(value >= min_value && value <= max_value)) {
pr_info("Error WMI call for reading brightness: expected a value between %u and %u, but got %d\n",
Expand All @@ -3810,9 +3818,17 @@ static int legion_wmi_light_set(struct legion_private *priv, u8 light_id,
buffer.length = 3;
buffer.pointer = &in_buffer_param[0];
in_buffer_param[0] = light_id;
in_buffer_param[1] = 0x01;
in_buffer_param[2] =
clamp(brightness + min_value, min_value, max_value);
if (light_id == LIGHT_ID_YLOGO) {
/* Y-Logo: DSDT checks SCST (byte 1) for on/off.
* EC convention: 1 = ON, 2 = OFF.
*/
in_buffer_param[1] = brightness ? 1 : 2;
in_buffer_param[2] = 0;
} else {
in_buffer_param[1] = 0x01;
in_buffer_param[2] =
clamp(brightness + min_value, min_value, max_value);
}

err = wmi_exec_int(LEGION_WMI_KBBACKLIGHT_GUID, 0,
WMI_METHOD_ID_KBBACKLIGHTSET, &buffer, &result);
Expand Down Expand Up @@ -6331,7 +6347,7 @@ static int legion_add(struct platform_device *pdev)
}

pr_info("Init IO-Port LED driver\n");
err = legion_light_init(priv, &priv->iport_light, LIGHT_ID_IOPORT, 1, 2,
err = legion_light_init(priv, &priv->iport_light, LIGHT_ID_IOPORT, 0, 2,
"platform::ioport");
if (err) {
dev_info(&pdev->dev,
Expand Down