Activity visual polish #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a WIP, because I'd like to get feedback on a few things. This commit does: - Lighten the separator component to match the design system - Reduce the hover state for navigation items vertically, and center it - Add RGB values to the green color in the Theme, which can be used via Qt.rgba to calculate transparencies (I used this in a test for more complex visual amount rendering, but need to clarify things there) - In transaction details, change the "Address" label to "To" or "From" based on the direction of the transaction - Makes transaction details amount bold - Makes transaction details circle white for sends - Tightens up some spacing in the activity list item to match the design system - Fixes an issue with the Icon component that caused images to be cropped and incorrectly sizes - Switches the Icon in the activity list item to an Image. The Icon component is based on a Button, so it's not quite appropriate. Also, Icon rendering gets blurry when the image is resized, while the Image renders crisp. I think there's a question here whether the Icon should be based on an image, or be called IconButton (and just be used for buttons)
johnny9
reviewed
Jul 4, 2025
johnny9
reviewed
Jul 4, 2025
Owner
johnny9
left a comment
johnny9
left a comment
There was a problem hiding this comment.
Looks like a lot of really nice changes in there
Contributor
Author
|
I just removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WIP, because I'd like to get feedback on a few things. Generally, I was looking to visually polish the activity and activity details screens. I am still becoming acquainted with the QML and how the various components are set up. This commit does:
Add RGB values to the green color in the Theme, which can be used via Qt.rgba to calculate transparencies. I used this in a test for more complex visual amount rendering, but need to clarify something there before committing code. It looks like the transaction object is getting a pre-formatted amount assigned, and that there are two formatting functions (satsToBtcStringandsatsToRichBtcString). I am thinking it might be better if the transaction has the raw satoshi amount, and then components apply whatever formatting is needed for local display.