Skip to content

Fix undefined resolveType issue#11

Open
adelsz wants to merge 1 commit intojoin-monster:masterfrom
adelsz:master
Open

Fix undefined resolveType issue#11
adelsz wants to merge 1 commit intojoin-monster:masterfrom
adelsz:master

Conversation

@adelsz
Copy link
Copy Markdown

@adelsz adelsz commented Aug 27, 2018

Interface and union types resolveType resolution was broken.
GraphQLInterfaceType, GraphQLUnionType were missing the resolveType after joinMonsterAdapt. This happened because resolveType field should be set at type level and not in type._typeConfig.

@frederikhors
Copy link
Copy Markdown

@adelsz is this related to this? #12

@adelsz
Copy link
Copy Markdown
Author

adelsz commented Sep 6, 2018

@frederikhors I don't think so. type._typeConfig is defined in this case.

@lorensr
Copy link
Copy Markdown
Member

lorensr commented Jan 22, 2020

@adelsz is this still an issue in the 0.1.0 version I just published?

@lorensr
Copy link
Copy Markdown
Member

lorensr commented Jan 22, 2020

@adelsz
Copy link
Copy Markdown
Author

adelsz commented Jan 24, 2020

Unfortunately, I won't be able to check this any time soon.
But it shouldn't be too hard to check/reproduce with a mock GraphQLInterfaceType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants