Skip to content

Conversation

watanka
Copy link

@watanka watanka commented Dec 22, 2024

Modernize codebase for current Django and Faker versions 🔄

Hi! 👋

I've noticed this wonderful package hasn't been updated in a while, so I wanted to help modernize some parts to work better with current versions.

Why this change? 🤔

The current codebase has some compatibility issues with recent versions of Django and Faker. This PR aims to resolve some of these issues to keep the package up-to-date and useful for the community.

What's Changed? ✨

1. Faker Compatibility (v33.1.0)

  • Updated method names to follow current Faker conventions
  • Example: userName()user_name()

2. Django Support (>=2.0.0)

  • Updated Django model handling
  • Added support for DurationField
  • Ensures compatibility with modern Django versions

Testing 🧪

  • All tests are passing with the updated changes
  • Added new test cases for DurationField support
    • Note: I've added these tests to verify the new functionality. Happy to remove or modify them based on your preferences!
  • Tested with:
    • Django: 2.0.0+
    • Faker: 33.1.0

Future Possibilities 🚀

This PR covers only some of the necessary updates. If you're interested, I'd love to help with further modernization efforts, such as:

  • Additional field type support
  • Documentation updates
  • More comprehensive testing

Let me know if you'd like me to make any adjustments to this PR or if you're interested in having more modernization work done! I'm happy to help! 😊


Thank you for maintaining this useful package! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants