Skip to content

Conversation

fliespl
Copy link

@fliespl fliespl commented May 4, 2025

No description provided.

Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks a lot for this contribution.

Can you run "make cs" to fix the Coding Standard?

Also is there a way to test this?

@@ -34,12 +39,30 @@ public static function create(string $token, ?ClientInterface $httpClient = null
// Decorates the HTTP client with some plugins
$uri = Psr17FactoryDiscovery::findUriFactory()->createUri('https://slack.com/api');
$pluginClient = new PluginClient($httpClient, [
new ErrorPlugin(),
new SlackErrorPlugin(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this plugin can stay here? Do you have an example of rate limiting response from Slack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants