fix: various error handling #1304
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
jonasoreland
approved these changes
Jan 5, 2026
not set for non GPS activities when swiching sctivities A few cleanups
only started after a pause. * each step was started multiple times * validateSeconds did not handle not parsable data
Incorrect error handling reported in Play Console
EdgeToEdge is implemented previously, this enables a Play Console suggestion.
gerhardol
force-pushed
the
feature/minor-fixes
branch
from
11614b3 to
2b518b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1288
Fixes #1289
Fixes #1290
Fixes #1302
Based on #1303
Rebase merge
Some minor fixes reported in Workout.onStart ignores passed scope and triggers all scopes (duplicates/incorrect events) #1288 WorkoutBuilder.validateSeconds accepts invalid inputs when initial parse fails (missing early return) #1289 TargetTrigger.onStart doesn’t unpause → trigger never fires after restart #1290
fix: check mGpsStatus in tick
not set for non GPS activities when switching activities
fix: various error handling
Incorrect error handling reported in Play Console.
The underlaying issue may be unhandled.
There are a few others too that were weird that I did not bother to address.
Most seem to be related to the spinner