After Closing Bug Dialog. It will still opened by ESC Key - #260
Open
Fox-Alpha wants to merge 2 commits into
Open
After Closing Bug Dialog. It will still opened by ESC Key#260Fox-Alpha wants to merge 2 commits into
Fox-Alpha wants to merge 2 commits into
Conversation
===: Close signal wont emit
Solution 1: Only check click in region of mainmenu if no submenu is active Solution 2 as comment: Check for active submenu and check the region for the submenu, queue_free() submenu if outside
Fox-Alpha
changed the title
Owner
|
I will review it once all the actions pass. Currently the formatting action is failing. You can use gdformat to fix the format and be in line with the rest of the code. |
Owner
|
More info can be found in the contribution guide: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Issue #244
Solution 1: Only check click in region of mainmenu if no submenu is active
Solution 2 as comment: Check for active submenu and check the region for the submenu, queue_free() submenu if outside
Solution 1 is working
At Solution 2, i think it was not 100% working.
Maybe the Dialog region is wrong
But you know your code better. Maybe there is a better point to fix this.
Please ignore the changes in ReportBugMenu.gd