Conversation
…ve. Fixed PACKAGE_VERSION in postinstall script for multiline version output - might happen on reinstalling package
Updated packaging for RPM and DEB
Rest api config to /etc/jasmin/rest-api.cfg
Update jasmind.py: - Enable DeliverSm Thrower service
DLR for SMS with more than one segment
Moved setting DLR mas from HTTP request before interception is done.
…erver-and-REST-API Add logging to stdout for HTTP server and REST API
udh segment_seqnum from the current part not always read it from first part
gartlady
reviewed
May 8, 2024
| if r.response.status == CommandStatus.ESME_ROK: | ||
| dlr = DLR(pdu_type=r.response.id, msgid=msgid, status=r.response.status, | ||
| smpp_msgid=r.response.params['message_id']) | ||
| dlr = DLR(pdu_type=_pdu.response.id, msgid=msgid, status=_pdu.response.status, |
There was a problem hiding this comment.
Hi,
I recently ran an apt update and got upgraded to v0.11.1. However, it seems that this version introduced a breaking bug related to DLRs. Specifically, _pdu is set to r.request on line 296, causing issues with fetching the response correctly.
I've locally reverted this change back to r.response, which has resolved my DLRMapNotFound issues.
It seems that this code change has not been merged to master yet or released on GitHub, but it has been released via apt (jasmin-sms-gateway/jammy,now 0.11.1 all [installed]).
I can create a PR to revert this change but I wanted to query it here first.
Cheers,
Dylan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #
Description
Checks
Additional Information