[6.3] [cli] AddUserCommand with password validation - #48361
Draft
alikon wants to merge 1 commit into
Draft
Conversation
Refactor password handling in AddUserCommand. Added getPasswordFromOption method for password input and validation.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the AddUserCommand to include password confirmation like in site/admin application.
Pull Request resolves #37629.
Summary of Changes
use the site/admin validation in cli
Testing Instructions
create a user using the cli
php cli/joomla.php user:addActual result BEFORE applying this Pull Request
no validation on password
Expected result AFTER applying this Pull Request
password validation as per site/admin form validation
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed