Fix buffer overflow in USRP recv_stream function #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add boundary check before memcpy to prevent buffer overflow - Calculate safe copy length to avoid writing beyond buffer bounds - Add break condition when buffer is filled - Fix type mismatch by changing current_index from int to size_t - Improve memory management by freeing result buffer on second malloc failure
|
|
Collaborator
|
Thank you for contributing this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a buffer overflow vulnerability in the USRP recv_stream function that caused crashes during data reception.
Problem
When receiving data from USRP devices (tested with B210), the
memcpyoperation could write beyond the allocated buffer boundary, causing a "buffer overflow detected" error and application termination.Solution
Testing
Tested with USRP B210 device:
Related Issue
Fixes buffer overflow crash when receiving data with USRP devices.