Skip to content

Fix error when saving compressed files#1197

Merged
jopohl merged 2 commits intomasterfrom
better-error
Dec 17, 2025
Merged

Fix error when saving compressed files#1197
jopohl merged 2 commits intomasterfrom
better-error

Conversation

@jopohl
Copy link
Owner

@jopohl jopohl commented Dec 17, 2025 •
edited
Loading

Fix two bugs:

  • On Windows, saving compressed files can cause issues as the temporary file is deleted before the archive is closed
  • Displaying the error didn't use the Errors.exception helper method the last argument may have an invalid type

@jopohl jopohl requested a review from Copilot December 17, 2025 13:07
@jopohl jopohl changed the title Improve error display and fix error when saving compressed files on Windows Fix error when saving compressed files on Windows and improve error display Dec 17, 2025
@jopohl jopohl changed the title Fix error when saving compressed files on Windows and improve error display Fix error when saving compressed files on Windows and fix error display Dec 17, 2025
@jopohl jopohl changed the title Fix error when saving compressed files on Windows and fix error display Fix error when saving compressed files Dec 17, 2025
@jopohl jopohl merged commit 7c946e0 into master Dec 17, 2025
15 checks passed
@jopohl jopohl deleted the better-error branch December 17, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jopohl