Fix error messages and update MysqL client version#2
Closed
bertrand-lorentz wants to merge 2 commits into
Closed
Conversation
Ensure the error message is displayed correctly when a required env variable is missing: add missing "echo" command and put the variable name in simple quotes instead of backticks so that it's not executed as a command. Fixes issue joseluisq#1.
The previous version 8.0.42-1debian12 is not available anymore in the repository.
Owner
No, the previous version still exists. Aside from that, can you please create a new PR for the version update just to track it separately? |
Contributor
Author
|
Thansk for the quick feedback. I got the following error from "docker build" with the previous version, so I thought I'd handle this in the same PR: I'm closing this PR and I'll open 2 new separate PRs, one for each change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of missing required env variable.
This also updates the MysQL client version, as the previous version is not available in the repository anymore, causing "docker build" to fail.