This repository was archived by the owner on Apr 24, 2025. It is now read-only.
Improve Types for $delegate and $resolve function#1567
Open
jBernavaPrah wants to merge 6 commits intojovotech:v4/latestfrom
Open
Improve Types for $delegate and $resolve function#1567jBernavaPrah wants to merge 6 commits intojovotech:v4/latestfrom
jBernavaPrah wants to merge 6 commits intojovotech:v4/latestfrom
Conversation
Added a *breaking change* in Jovo.$resolve typing. I'm try to find a better way without the necessity to change the type of ARGS, but for now it's working for the delegateComponent.
Author
|
Update the PR with a fix to improve the typing when used with arrays of type. This last change introduces a breaking change because of the generic ARGS of Jovo.$resolve needs to be compatible with a tuple and not with an array. So now, if users use only BaseComponent, typescript will trigger errors when multiple parameters will be used in the $resolve. Es: this.$resolve('event', "resolve1", "resolve2") // The resolve2 will be highlight by typescript as errorHappy to improve and remove this breaking change if someone has some suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added a new abstract Class
BaseDelegateComponentand anExtractDelegatedEventDatatype to permit better use of $delegate and $resolve functions.The
BaseDelegateComponent, used in a similar way as the BaseComponent, is there to add the typing to events/resolve.The
ExtractDelegatedEventDatais used to extract the data from the event.Examples (pseudo code):
Completely open to discussing it in any way.
Types of Changes
Checklist