Added support for parsing the unit tag in mesh (DAE) files referenced by URDF.#266
Open
Michi-Tsubaki wants to merge 2 commits intojsk-ros-pkg:masterfrom
Open
Added support for parsing the unit tag in mesh (DAE) files referenced by URDF.#266Michi-Tsubaki wants to merge 2 commits intojsk-ros-pkg:masterfrom
Michi-Tsubaki wants to merge 2 commits intojsk-ros-pkg:masterfrom
Conversation
Author
|
The size issue has been resolved. However, as for mycobot 280, it is necessary to fix the issue where joint1_lk is not included in the joint list. Without resolving this, the IK solver cannot compute a valid solution . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #265
Summary
Problems
Currently euscollada does not read unit tag in dae files, and use hardcoded "1000" constant value to convert meter(default unit

of .dae) to milimeter(default unit of euslisp). However, in case of mycobot280, the unit of the mesh file of base is Milimeter while others are Meter.
Changes
getDaeUnitMeter()that reads from a.daefile using raw string search.Backward-compatible
non-DAE or DAE without both return 1.0 → unit_scale = 1000.0 (same as before).
Note that
I intentionally parse the tag via string search rather than using Assimp because the version of Assimp currently used here does not support unit value. Thus directly reading the raw file content is more robust and ensures backward compatibility.