add resize and timer_rate option in tile_image to reduce cpu load#2881
Open
knorth55 wants to merge 5 commits intojsk-ros-pkg:masterfrom
Open
add resize and timer_rate option in tile_image to reduce cpu load#2881knorth55 wants to merge 5 commits intojsk-ros-pkg:masterfrom
knorth55 wants to merge 5 commits intojsk-ros-pkg:masterfrom
Conversation
mqcmd196
requested changes
Jan 18, 2026
Member
mqcmd196
left a comment
mqcmd196
left a comment
There was a problem hiding this comment.
CI fails at
[ERROR] [1768658916.019819]: bad callback: <bound method Subscriber.callback of <message_filters.Subscriber object at 0x7f61d8c8c9a0>>
Traceback (most recent call last):
File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
cb(msg)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/__init__.py", line 76, in callback
self.signalMessage(msg)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/__init__.py", line 58, in signalMessage
cb(*(msg + args))
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/__init__.py", line 330, in add
self.signalMessage(*msgs)
File "/opt/ros/noetic/lib/python3/dist-packages/message_filters/__init__.py", line 58, in signalMessage
cb(*(msg + args))
File "/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/node_scripts/tile_image.py", line 181, in _apply
self._append_images(imgs)
File "/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/node_scripts/tile_image.py", line 127, in _append_images
shape_xy = get_tile_shape(len(imgs))
NameError: name 'get_tile_shape' is not defined
Member
Author
|
@mqcmd196 Thanks! I updated. |
mqcmd196
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, I add resize and timer_duration to reduce CPU load of this node.
Current implementation
This PR