This repository was archived by the owner on Jan 8, 2025. It is now read-only.
Bug: Cannot retrieve stories from an interation#71
Open
amair wants to merge 2 commits intojsmestad:masterfrom
Open
Bug: Cannot retrieve stories from an interation#71amair wants to merge 2 commits intojsmestad:masterfrom
amair wants to merge 2 commits intojsmestad:masterfrom
Conversation
|
👍 for this. Tested it and this fixes the issue mentioned. |
|
👍 This looks like it resolves issue #67. |
Contributor
|
👍 My testing also confirms that this fixes #67. |
|
+1 let's get this in, I was just bitten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the change to nokogiri-happymapper broke the ability to retrieve story data from an iteration. I enlcose a test which demonstrates the problem and the xpath change required to resolve it.
hth!