Update Instructions, fix dependencies #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RileyDavidson
commented
Sep 24, 2021
RileyDavidson
commented
- Added setup instructions to readme
- Added missing include
- Changed from find_library to find_package for gflags
- Removed broken(?) asserts
Update readme to add instructions
Removing what appears to be broken asserts, they always fail. Might actually be needed? Added missed dependency
Changed to find_package
RileyDavidson
commented
Sep 24, 2021
| __builtin_ctzl(valid_orientation_[piece]))) { | ||
| if (fixed_[at]) { | ||
| assert(fixed_[at] == piece_mask(piece)); | ||
| //assert(fixed_[at] == piece_mask(piece)); |
Author
There was a problem hiding this comment.
Not sure why this fails every time I run gen
|
|
||
| for (int piece = 0; piece < N; ++piece) { | ||
| assert(count[piece] == hints_[piece].second); | ||
| //assert(count[piece] == hints_[piece].second); |
Author
There was a problem hiding this comment.
Not sure why this fails every time I run gen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.