Repository navigation
Test relative JSON Pointer index manipulation - #1032
Draft
dev-willbird1936 wants to merge 3 commits into
Draft
dev-willbird1936 wants to merge 3 commits into
dev-willbird1936 wants to merge 3 commits into
Conversation
Open
4 tasks done
Member
|
We've recently completed a major update to format validation as part of a Google Summer of Code project. Several tests were added already. Please review the recent changes. If those are enough, great! Otherwise, please rebase your branch and include any tests you think are still missing. Sorry of the delay. |
Member
|
@dev-willbird1936 These tests will need to be added to draft7 and draft2019-09 as well. @vtushar06 Would you mind reviewing this? I'm guessing you might be more familiar with the spec than me at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Draft 2020-12 added the optional
+N/-Nindex-manipulation production, but the shared format suite did not exercise it. These cases provide implementation-neutral coverage and are a prerequisite for python-jsonschema/jsonschema#1534.Specification: https://json-schema.org/draft/2020-12/relative-json-pointer
Validation
python -m json.toolfor both changed filespython bin/jsonschema_suite check— 11 checks passed, 4 skippedgit diff --check