[fix] : Adjusted the Menu DropDown the Navigation Top Bar #1712
Conversation
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@benjagm @idanidan29 Can u review this PR? |
|
@Utkarsh-123github Can I know what is unclear in this PR? So that I can make changes accordingly.. |
|
Hey @Yashwanth1906 , this PR is completely fine, actually I was adding the PRs to the PR board, so for the initial step I need to add all the PRs to unclear stage and then to Ready to review status. I'll make the changes by the EOD. |
|
@Utkarsh-123github Okay fine. |
|
Hi @Yashwanth1906 , I observed that you have raised 2 different PRs for the same issue. Could you please close one of the PR which is outdated, so that PR reviewing could be easier and duplication is avoided. |
|
@Utkarsh-123github This PR is about fixing the top bar issue #1578 . and the #1518 is about fixing the sidebar toggle. Both are different issues. |
|
@Yashwanth1906 but you have mentioned in both the PR description the same issue #1484 . I guess you have tagged the wrong issue, kindly update the PR description. |
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
@Utkarsh-123github I have updated the PR description. Btw, sry for the wrong pr description. |
|
No worries at all, thanks for fixing it! 🙌 |
|
Hey @Yashwanth1906 , you've done a great job ! 2025-06-28.13-31-00.mp4 |
Utkarsh-123github
left a comment
Utkarsh-123github
left a comment
There was a problem hiding this comment.
Please refer to the attached video and try to fix it. Thank you!
Utkarsh-123github
moved this from Ready to review
to Changes requested
in PR - Triage Group
@Yashwanth1906 has done a great job here. I’ve reviewed the code, and I noticed @Utkarsh-123github that point mentioned in the video still needs to be addressed. I’m not sure why there hasn’t been a response yet, but that’s okay. If you’d like @Utkarsh-123github , I can provide fixes for the issues you pointed out, directly in this PR. Please let me know if that works for you. |
|
sorry for the late response @Utkarsh-123github I had my semesters . I'll fix this by this weekend. @sonu-ind-dev |
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Fine @Yashwanth1906, |
[feat] : Done with Top bar menu handling and scroll lock
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
@Yashwanth1906 Why I am getting option to approve your PR. Can you please explain me about this. |
I would suggest you to look into the issues that have good first issue tag and try to work on those issues. |
Everyone has the option to review others pr but we won't have the rights to merge them. @sonu-ind-dev I would suggest u to join json schema slack and post ur doubts over there. 🙂 |
Ok @Yashwanth1906 , Thanks for the suggestions & guidance. |
|
Hi @Yashwanth1906 , your PR is failing checks, please make the necessary changes and fix it. |
[fix]: Lint fixed
…906/website into Top-bar-menu-mobile-dimension
|
Hi @Yashwanth1906! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: kind of change description Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
|
@Utkarsh-123github I have Closed the #1518 PR and I have solved the #1484 In this PR itself. |
3 participants
What kind of change does this PR introduce?
🐛 Bugfix — fixes the scroll lock and layout shift issue when opening the navigation menu on mobile view.
Issue Number:
Closes #1578
Screenshots/videos:
N/A (functional CSS-level fix; visual change is subtle and responsive)
If relevant, did you update the documentation?
Not applicable — no changes required to documentation.
Summary
This PR resolves the issue when the top bar is menu is opened in mobile dimension the content of the page is getting hidden.
More Detail Issue Description: #1578.
Fix implemented:
Does this PR introduce a breaking change?
No breaking changes — the fix is isolated to the responsive mobile layout.