fix: normalize badge height for all tool reports (#1753) #1756
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 548 548
Branches 158 158
=========================================
Hits 548 548 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -388,6 +388,7 @@ const BowtieReportBadge = ({ uri }: { uri: string }) => { | |||
| className='my-1' | |||
| width={100} | |||
| height={20} | |||
| style={{ width: 'auto', height: '20px', objectFit: 'contain' }} | |||
There was a problem hiding this comment.
Hey @animeshsahoo1 , your approach is fine, but since we are using TailwindCSS in our codebase, so I think this issue can be fixed with a single change in the TailwindCSS classes.
I'd suggest instead of adding full CSS style tag, just add a 'w-auto h-[20px]' in the Tailwind class and the issue will get fixed.
There was a problem hiding this comment.
Hey @animeshsahoo1 , I have reviewed and suggested some changes in your PR. Please have a look over it and make the appropriate changes.
Thank You!🚀
Utkarsh-123github
moved this from Ready to review
to Changes requested
in PR - Triage Group
|
@Utkarsh-123github I have made the changes, thanks for your patience. |
Utkarsh-123github
moved this from Changes requested
to Waiting for others to Review
in PR - Triage Group
|
@Utkarsh-123github you are welcome looking forward to making more meaningful contributions. |
What kind of change does this PR introduce?
A bugfix — it ensures that all dynamically generated badge images render at a consistent height/size.
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
NO
Summary
The issue was to make all the badges of same height, first I tried to see if there's any way to fix the size of badges by changing
shield.io endpoint URL by adding certain queries, as it was not possible to do so written in their QnA in github, i manually added styles to the image to keep the height same for all badges
Does this PR introduce a breaking change?
NO
Checklist
Please ensure the following tasks are completed before submitting this pull request.