Skip to content

Fix supportedDialects for v8r #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chris48s
Copy link
Contributor

@chris48s chris48s commented Jul 19, 2025

What kind of change does this PR introduce?

Update tooling data file

Issue Number:

Screenshots/videos:

n/a

If relevant, did you update the documentation?

n/a

Summary

Fix the supportedDialects value for v8r. Source:
https://chris48s.github.io/v8r/faq/#-what-json-schema-versions-are-compatible

This data was correct in

date-draft: [2020-12, 2019-09]
draft: [7, 6, 4]

It looks like this may have been migrated incorrectly in 33dbd28

I've not really dug into it, but having cherry-picked a few examples, it does look like there are other projects where the content from the date-draft field was lost 😬

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@chris48s chris48s requested a review from a team as a code owner July 19, 2025 17:57
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jul 19, 2025
Copy link

Hi @chris48s! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

Hi @chris48s! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

github-actions bot commented Jul 19, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview af916a5

Copy link

Hi @chris48s! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

1 similar comment
Copy link

Hi @chris48s! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: issue reference

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8ea58e7) to head (af916a5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1772   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          553       553           
  Branches       161       161           
=========================================
  Hits           553       553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

supportedDialects value is incorrect for v8r
1 participant