-
-
Notifications
You must be signed in to change notification settings - Fork 282
Fix supportedDialects for v8r #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @chris48s! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Hi @chris48s! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Hi @chris48s! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
1 similar comment
Hi @chris48s! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: issue reference Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 553 553
Branches 161 161
=========================================
Hits 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What kind of change does this PR introduce?
Update tooling data file
Issue Number:
Screenshots/videos:
n/a
If relevant, did you update the documentation?
n/a
Summary
Fix the
supportedDialects
value for v8r. Source:https://chris48s.github.io/v8r/faq/#-what-json-schema-versions-are-compatible
This data was correct in
website/data/validator-libraries-modern.yml
Lines 574 to 575 in f83ccfe
It looks like this may have been migrated incorrectly in 33dbd28
I've not really dug into it, but having cherry-picked a few examples, it does look like there are other projects where the content from the
date-draft
field was lost 😬Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.