feat: Add CaseInsensitiveSet with original casing support
#576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a custom `Set`-like class `CaseInsensitiveSet` that performs case-insensitive string operations. - Internally uses a `Map<string, T>` to store normalized keys and preserve the first-in original casing. - Implements standard methods: `add`, `delete`, `has`, `clear`, `forEach`, `entries`, `keys`, `values`, and `[Symbol.iterator]`. - Supports method chaining and uses locale-aware normalization via `toLocaleLowerCase()`.
- Covers construction with default and custom iterables, including case deduplication. - Verifies core methods: `add`, `delete`, `has`, `clear`, `forEach`, `values`, `keys`, `entries`, and iteration support. - Ensures case-insensitive logic works across registries, scripts, Unicode, and large strings. - Adds tests for real-world usage patterns including CLI simulation and integration scenarios. - Validates original casing preservation and locale-aware behavior.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces a CaseInsensitiveSet to handle string deduplication in a case-insensitive manner—preserving the casing of the first occurrence—and swaps it in place of native Set in repo init/add commands.
- Adds a
CaseInsensitiveSetimplementation with full Set-like API and locale-aware normalization - Updates
initandaddcommands to replaceSetwithCaseInsensitiveSetfor repository lists - Adds a comprehensive Vitest suite covering functionality, edge cases, performance, and CLI integration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/case-insensitive-set.test.ts | New test suite validating all operations, edge cases, and CLI use |
| src/utils/case-insensitive-set.ts | New CaseInsensitiveSet class using a Map for case-insensitive storage |
| src/commands/init.ts | Replaces native Set with CaseInsensitiveSet in initialization |
| src/commands/add.ts | Replaces native Set with CaseInsensitiveSet in add command |
Comments suppressed due to low confidence (1)
src/utils/case-insensitive-set.ts:81
- [nitpick] The second parameter
_value2inforEachis unused and may confuse readers; consider renaming it to_keyor omitting the underscore prefix to better reflect its purpose in a Set callback.
callbackfn: (value: T, _value2: T, set: CaseInsensitiveSet<T>) => void,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CaseInsensitiveSetclass using aMapfor case-insensitive operations.add,delete,has,clear,forEach,entries,keys,values, and iteration.toLocaleLowerCase().Replaces
SetwithCaseInsensitiveSetininitandadd.Closes #515