Skip to content

Fix imapfetch to actually use the 'port' argument #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimduchek wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix imapfetch to actually use the 'port' argument #468

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23be874
Fix imapfetch to actually use the 'port' argument
jimduchek Jun 9, 2026
2b6fa61
Fix importing the imap settings from the db.
jimduchek Jun 11, 2026
e64da62
Fixed typo in IMAP4_SSL_PORT constant
jimduchek Jun 12, 2026
58ba4fc
Fixed ANOTHER typo in IMAP4_SSL_PORT
jimduchek Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions util/imapfetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def main():
default="/etc/piler/piler.conf")
parser.add_argument("--security", type=str, help="imap security. no, TLS or SSL", default="no")
parser.add_argument("-s", "--server", type=str, help="imap server")
parser.add_argument("-P", "--port", type=int, help="port number", default=143)
parser.add_argument("-P", "--port", type=int, help="port number")
parser.add_argument("-u", "--user", type=str, help="imap user")
parser.add_argument("-p", "--password", type=str, help="imap password")
parser.add_argument("--oauth2-token", type=str, help="oauth2 access token file")
Expand Down Expand Up @@ -162,6 +162,7 @@ def main():
server = ''
user = ''
password = ''
port = None

if args.import_from_table:
read_options(args.config, opts)
Expand All @@ -176,6 +177,10 @@ def main():
row = cursor.fetchone()
if row:
(opts['id'], security, server, user, password) = row

server, _, port = server.partition(":")
port = port or None

security = row[1]
else:
print("Nothing to read from import table")
Expand All @@ -188,16 +193,17 @@ def main():
server = args.server
user = args.user
password = args.password
port = args.port

if opts['verbose']:
print("Skipped folder list: {}".format(opts['skip_folders']))

if security in ('no', 'imap'):
conn = imaplib.IMAP4(server)
conn = imaplib.IMAP4(server, port = port if port is not None else imaplib.IMAP4_PORT)
elif security == 'imap-ssl':
conn = imaplib.IMAP4_SSL(server)
conn = imaplib.IMAP4_SSL(server, port = port if port is not None else imaplib.IMAP4_SSL_PORT)
elif security == 'imap-tls':
conn = imaplib.IMAP4(server)
conn = imaplib.IMAP4(server, port = port if port is not None else imaplib.IMAP4_PORT)
conn.starttls()

if opts['access_token']:
Expand Down