Skip to content

Bug fixes XlsxReader #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug fixes XlsxReader #1253

wants to merge 1 commit into from

Conversation

@roelandmaes
Copy link

@roelandmaes roelandmaes commented Apr 19, 2024 •
edited
Loading

Thanks for contributing.

Description

Bug fixes for the XlsxReader.
XlsxReader was not able to read Excel sheets with only a header and no data.
XlsxReader was not able to read Excel sheets with empty rows.

Testing

Nope

benmccann
benmccann requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the formatting changes. A test should probably be added as well though it's hard to make a call on that as this diff is currently unreadable

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roelandmaes @benmccann