Skip to content

fix: anon long form func definition #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: anon long form func definition #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4bc817
fix: anon long form func definition
pfitzseb Jun 11, 2024
a753737
fix: correct anon func block parsing on old julia versions
pfitzseb Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/packagedef.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,10 @@ Parses an expression starting with a `(`.
function parse_paren(ps::ParseState)
args = EXPR[]
trivia = EXPR[EXPR(ps)]
@closeparen ps @default ps @nocloser ps :inwhere parse_comma_sep(ps, args, trivia, false, true, true, insert_params_at = 1)

anon_func_block = VERSION < v"1.11-" || kindof(ps.lt) != Tokens.FUNCTION

@closeparen ps @default ps @nocloser ps :inwhere parse_comma_sep(ps, args, trivia, false, anon_func_block, true, insert_params_at = 1)
if length(args) == 1 && length(trivia) == 1 && ((kindof(ps.ws) !== SemiColonWS || headof(args[1]) === :block) && headof(args[1]) !== :parameters)
accept_rparen(ps, trivia)
ret = EXPR(:brackets, args, trivia)
Expand Down
3 changes: 3 additions & 0 deletions test/parser/test_parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ end
@test "-1^a" |> test_expr
@test "function(f, args...; kw...) end" |> test_expr
@test "function(f, args...=1; kw...) end" |> test_expr
@test "function (f; args...) end" |> test_expr
@test "function (; args...) end" |> test_expr
@test "function (args...) end" |> test_expr
@test "2a * b" |> test_expr
@test "(g1090(x::T)::T) where {T} = x+1.0" |> test_expr
@test "(:) = Colon()" |> test_expr
Expand Down