Skip to content

fix(ios): CVPixelBuffer race condition crash in captureOutput #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harSofja wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −4
Open

fix(ios): CVPixelBuffer race condition crash in captureOutput #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## NEXT
## 7.2.1

**Improvements**

Expand All @@ -7,6 +7,10 @@
* [Web] The camera now uses `StartOptions.cameraResolution` as the ideal resolution, falling back to 1920×1080.
* [Web] The barcode overlay is now mirrored when the video preview is mirrored (e.g. front camera).

**Bug Fixes**

* [Apple] Fixed a race condition in `captureOutput` where `latestBuffer` was read on a background thread after being deallocated on the main thread, causing a crash in `VTCreateCGImageFromCVPixelBuffer`.

## 7.2.0

**Highlights**
Expand Down
5 changes: 3 additions & 2 deletions darwin/mobile_scanner/Sources/mobile_scanner/MobileScannerPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,13 @@ public class MobileScannerPlugin: NSObject, FlutterPlugin, FlutterStreamHandler,
if ((detectionSpeed == DetectionSpeed.normal || detectionSpeed == DetectionSpeed.noDuplicates) && eligibleForScan || detectionSpeed == DetectionSpeed.unrestricted) {
nextScanTime = currentTime + timeoutSeconds
imagesCurrentlyBeingProcessed = true
let bufferToProcess = latestBuffer
DispatchQueue.global(qos: .userInitiated).async { [weak self] in
guard let self = self else {
return
}
guard let buffer = self.latestBuffer else {

guard let buffer = bufferToProcess else {
self.imagesCurrentlyBeingProcessed = false
return
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: mobile_scanner
description: A universal Flutter barcode and QR code scanner using CameraX/ML Kit for Android, AVFoundation/Apple Vision for iOS & macOS, and ZXing for web.
version: 7.2.0
version: 7.2.1
repository: https://github.com/juliansteenbakker/mobile_scanner

screenshots:
Expand Down