Skip to content

chore: Update ProGuard rules for ML Kit - #1763

Merged
juliansteenbakker merged 3 commits into
developfrom
navaronbracke-patch-1
Sep 2, 2026
Merged

chore: Update ProGuard rules for ML Kit#1763
juliansteenbakker merged 3 commits into
developfrom
navaronbracke-patch-1

Conversation

@navaronbracke

Copy link
Copy Markdown
Collaborator

Investigating #1725

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.85%. Comparing base (9d93864) to head (571c80a).
⚠️ Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1763      +/-   ##
===========================================
+ Coverage    60.40%   62.85%   +2.44%     
===========================================
  Files           48       48              
  Lines         1225     1233       +8     
===========================================
+ Hits           740      775      +35     
+ Misses         485      458      -27     
Flag Coverage Δ
unittests 62.85% <ø> (+2.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliansteenbakker juliansteenbakker left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be { *; } instead of { ; } on all three lines? R8 fails to parse the rules file right now.

@navaronbracke

Copy link
Copy Markdown
Collaborator Author

Woops, yeah, typo. Fixed now

@juliansteenbakker juliansteenbakker left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seemed to be an issue with the spaces used. I've replaced them for plain spaces, looks good to me now.

@juliansteenbakker
juliansteenbakker merged commit aa59895 into develop Sep 2, 2026
14 checks passed
@juliansteenbakker
juliansteenbakker deleted the navaronbracke-patch-1 branch September 2, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants