Skip to content

Conversation

juntyr
Copy link
Owner

@juntyr juntyr commented Dec 28, 2022

  • strengthened all Habitat-derived cog pre-conditions s.t. Locations and IndexedLocations must be habitable, not just within bounds
  • removed the IndexedLocation index hack, use the full u32 instead
  • removed the GlobalLineageReference representation hack, use the full u64 instead
  • optimised the WrappingNoiseHabitat to use wrapping 2d noise instead of 4d noise
  • pulled in a better EventBuffer from Upgrade to async CUDA memory transfers and kernel launches #230
  • changed the PackedEvent representation to retain its packed size despite the removed hacks

@juntyr juntyr changed the title Refactor optimisations Refactoring and optimisations Dec 28, 2022
Copy link
Owner Author

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@codecov-commenter
Copy link

Codecov Report

Merging #238 (b0108ef) into main (18e388b) will decrease coverage by 1.11%.
The diff coverage is 3.29%.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   16.31%   15.19%   -1.12%     
==========================================
  Files         303      315      +12     
  Lines       20010    21395    +1385     
==========================================
- Hits         3264     3252      -12     
- Misses      16746    18143    +1397     
Impacted Files Coverage Δ
necsim/core/bond/src/closed_unit_f64.rs 0.00% <0.00%> (ø)
necsim/core/bond/src/off_by_one_u64.rs 26.38% <0.00%> (-2.40%) ⬇️
necsim/core/src/cogs/dispersal_sampler.rs 0.00% <0.00%> (ø)
necsim/core/src/cogs/lineage_store.rs 0.00% <0.00%> (ø)
necsim/core/src/cogs/speciation_probability.rs 0.00% <0.00%> (ø)
necsim/core/src/cogs/turnover_rate.rs 0.00% <0.00%> (ø)
necsim/core/src/reporter/filter.rs 0.00% <0.00%> (ø)
necsim/core/src/reporter/impl.rs 0.00% <0.00%> (ø)
necsim/impls/cuda/src/event_buffer.rs 0.00% <0.00%> (ø)
necsim/impls/cuda/src/lib.rs 100.00% <ø> (ø)
... and 56 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@juntyr juntyr marked this pull request as ready for review December 28, 2022 11:44
@juntyr juntyr merged commit 762bd04 into main Dec 28, 2022
@juntyr juntyr deleted the refactor-optimisation branch December 28, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants