WIP: Upload build logs to S3 - #1161
Closed
manics wants to merge 4 commits into
Closed
Conversation
aioboto* requires compiled dependencies which may not be available as wheels
This ensures logs are uploaded for failed builds
Member
|
Following comments in jupyterhub/repo2docker#967 , if we do it on the binderhub side, I think a sidecar container in the build pod might be a better way to go because we don't have to think about the consequences of binder pod replicas and restarts. A build can have 0, 1, or 2 (or more) RequestHandlers and binder pods watching it, whereas doing it in repo2docker (or in the build pod at least) should mean the lifecycle and everything is more naturally aligned. Cases we would need to handle if we did at the level in this PR:
|
Member
Author
|
Thanks... after reading the feedback on jupyterhub/repo2docker#967 I think r2d is the best (and easiest) place for it, let's continue on jupyterhub/repo2docker#967 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playing around with S3 logs again (#1156). This time uploading repo2docker logs from the BinderHub side instead of the repo2docker side.